goleveldb not up-to-date in glide?

[abraithwaite]

This is the current fork of goleveldb in master:

btcsuite/goleveldb@7834afc

However, it doesn't seem to include the performance fix (which you suggested):

syndtr/goleveldb@a49846e

https://github.com/btcsuite/goleveldb/blob/7834afc9e8cd15233b6c3d97e12674a31ca24602/leveldb/util/hash.go

Found while investigating slowness bootstrapping a full node. :-)

[abraithwaite]

Applying the patch reduces the time spent in GC from 50% to 30% on my platform, FWIW.

[abraithwaite]

Suppose this project is dormant. Oh well, thanks for the great libraries for working with the blockchain anyway!

[jcvernaleo]

@abraithwaite btcd is definitely not dormant. This time of year with holidays people tend to be busy and don't always respond to things too quickly though.

Also, generally we've been pretty conservative with leveldb versions.

[abraithwaite]

Good to hear! Understand about the holidays. Just assumed based on the activity. Apologies.

I was hoping that this patch could be applied to the vendored leveldb though, considering that it appears davecgh suggested it! :-)

syndtr/goleveldb#141

[red010b37]

Just as a FYI I see that that there is now a PR to upgrade to dep from glide.

#1130

[jakesylvestre]

addressed in #1575