Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance] Fast filtering #99

Open
michelole opened this issue Aug 30, 2019 · 1 comment
Open

[Performance] Fast filtering #99

michelole opened this issue Aug 30, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@michelole
Copy link
Member

Given #60 , re-arrange filtering rules so that most important ones (i.e. filters most) are hit first, thus making the code faster.

Also, move away from e.g. _compute_expansion_valid designed for testing and have a "fail-fast" (i.e. return false on first miss) version of it inside is_expansion_valid.
@michelole michelole added the enhancement New feature or request label Aug 30, 2019
@michelole michelole changed the title Fast filtering [Performance] Fast filtering Sep 4, 2019
@michelole
Copy link
Member Author

michelole commented Sep 4, 2019 •
edited
Loading

Also, levenshtein is really slow (#105), so it should be called last while #105 is not fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michelole