Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to fork for JDK9 support #64

Closed
beikov opened this issue Oct 5, 2016 · 7 comments
Closed

Add option to fork for JDK9 support #64

beikov opened this issue Oct 5, 2016 · 7 comments
Assignees
Milestone

Comments

@beikov
Copy link
Contributor

beikov commented Oct 5, 2016

I just ran into an issue with this plugin and JDK 9. One of my annotation processors uses a module that isn't visible by default, thus I have to add the module via command line flags. Apparently the module is not picked up by javac if it's running in the same JVM so creating a forked javac would solve the issue.

Can you provide a option similar to what other plugins provide?

@beikov
Copy link
Contributor Author

beikov commented Oct 5, 2016

Note that a workaround is to add the modules to MAVEN_OPTS and also via compilerArguments.

@bsorrentino
Copy link
Owner

Hi, thank for feedbacks

Interesting topic ....probably the issue could be solved adding a new ad-hoc argument

what do you think about ?

@beikov
Copy link
Contributor Author

beikov commented Oct 5, 2016

I'm not sure what you mean by ad hoc argument. Could you elaborate?

@bsorrentino
Copy link
Owner

I mean a new configuration tag in your case fork (<fork>true</fork>) like for example the maven-compiler-plugin

However i suppose that you for module mean a jar, if it is so, have you tried to add it as plugin and/or project dependency ?

@beikov
Copy link
Contributor Author

beikov commented Oct 7, 2016

No what I mean in the JDK 9 sense are modules available on the module path like e.g. java.xml.bind.
The <fork>true</fork> tag is exactly what is needed!

@bsorrentino bsorrentino modified the milestones: 3.2, 3.3 Oct 7, 2016
@bsorrentino bsorrentino self-assigned this Oct 7, 2016
@bsorrentino
Copy link
Owner

bsorrentino commented Mar 28, 2017

Hi
I've deployed version 3.3-SNAPSHOT with support of fork property

Plugin now read maven.compiler.source and maven.compiler.target to set out of process compiler (default is 1.7)

If you have chance to test it, I really appreciate that

Thanks in advance

@bsorrentino
Copy link
Owner

released in version 3.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants