Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix#216 : Added tags selection component #217

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yashpatil641
Copy link
Contributor

@yashpatil641 yashpatil641 commented Jul 23, 2024

Overview

  1. This PR fixes or fixes part of [Feature Request]: Add "tags" selection component  #216.
  2. This PR does the following: Adds tags selection component.

Essential Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • "Allow edits from maintainers" is checked. (See here for instructions on how to enable it.)
  • The PR is made from a branch that's not called "main/master".

Proof that changes are correct

tags.mp4

PR Pointers

  • If you need a review or an answer to a question, and don't have permissions to assign people, leave a comment like the following: "{{Question/comment}} @{{reviewer_username}} PTAL".
  • Never force push. If you do, your PR will be closed.

Copy link

netlify bot commented Jul 23, 2024

Deploy Preview for merch-site ready!

Name Link
🔨 Latest commit decce70
🔍 Latest deploy log https://app.netlify.com/sites/merch-site/deploys/669fb1c0cb9bc20008fdba3a
😎 Deploy Preview https://deploy-preview-217--merch-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AkashPaloju
Copy link
Collaborator

AkashPaloju commented Jul 25, 2024

@yashpatil641
Can you show the existing tags initially passed by the parent component? Does this component match substrings?
I mean - if there is no "xyz" tag and there is an "shirt-xyz" tag in the initial tags, if a user types "xyz", "shirt-xyz" will still be visible in the suggestions?

Tip: In the parent component, you can temporarily display the "tags" values on the page to verify correct emission to the parent component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants