-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change high-level auth to a wrapper around keyed Blake2b #88
Conversation
This relates to #58. Instead of changing the return type for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this. Apart from some minor details, the only major changes I think we need are:
- We want a 32-byte secret key and tag.
- I think it would be good to enforce a minimum 32-byte secret key, to avoid misuse.
Please see the comments for details.
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
=========================================
Coverage ? 95.77%
=========================================
Files ? 36
Lines ? 5612
Branches ? 0
=========================================
Hits ? 5375
Misses ? 237
Partials ? 0 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 97.31% 97.32% +0.01%
==========================================
Files 46 46
Lines 5590 5614 +24
==========================================
+ Hits 5440 5464 +24
Misses 150 150
Continue to review full report at Codecov.
|
For future reference: The reason that a 32-byte key and tag have been chosen is due to this being in line with what libsodium recommends in its generic-hash interface, as well as this answer. |
This should now state the use of BLAKE2b. Fixed in 16d0e94 |
Let me know if this is what you had in mind for a "wrapper" around keyed Blake2b. I think this is what we discussed, but obviously I'm happy to make changes.