Argon2i #113
Merged
Argon2i #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=========================================
Coverage ? 97.66%
=========================================
Files ? 55
Lines ? 7715
Branches ? 0
=========================================
Hits ? 7535
Misses ? 180
Partials ? 0
Continue to review full report at Codecov.
|
…ill_block (equivalent name to ref impl)
…ary vectors for permutation_p once.
…ory block size (128)
…est vectors to hit these branches: n. 13 where we don't enter while loop and n. 14 where we do (with out lengths of 94 and 97, respectively)
…ved because they took too long to complete
…meout to two minutes from the default one.
…ng of each segment, and incremented by one for each n in offset..segment length. Because memory cost cannot be above u32::max_value(), segment_length will never reach a point were the 64-bit counter on Gidx could overflow.
…rt. Modify too resource-intensive test
brycx
commented
Feb 1, 2020
| @@ -750,7 +750,7 @@ macro_rules! construct_secret_key_variable_size { | |||
| /// # } | |||
| /// ``` | |||
| pub struct $name { | |||
| value: Vec<u8>, | |||
| pub(crate) value: Vec<u8>, | |||
There was a problem hiding this comment.
This is set to pub(crate) so we avoid allocation two different Vec<u8>s in orion::kdf which hold sensitive data.
…ted with the reference implementation
…on, which include secret value and associated data parameters
…meters with leading zeroes
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #109.
TODO:
hazardous. How should the allocations for the memory blocks be handled?orion::pwhashandorion::kdf. What parameters should be used as default for each of those high-level APIs?Edit: I haven't been able to get a solution working, that doesn't require heap allocation. Thus, the Argon2i implementation will not be available with
no_std.