Updated attribute assignment to be chef 11 compatible

[adnichols]

The old attribute assignment behavior in this recipe isn't compatible w/ chef 11 - this PR changes that behavior to be compatible. It appears to work in my basic tests.

[adnichols]

Sorry - I didn't mention the 2nd change I made which is to merge the server['queries'] value instead of just overwriting it on line 23. This allows you to specify a custom query in attributes which didn't appear to be incorporated before.

[bryanwb]

i really, really don't recommend using jmxtrans

i suggest checking out my collectd::generic_jmx recipe instead,
collectd:GenericJMX is rock solid, unlike jmxtrans

On Mon, Mar 18, 2013 at 9:02 PM, Aaron Nichols [email protected]:

Sorry - I didn't mention the 2nd change I made which is to merge the
server['queries'] value instead of just overwriting it on line 23. This
allows you to specify a custom query in attributes which didn't appear to
be incorporated before.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-15078074
.

[adnichols]

Good to know. For folks who try this with chef11 though this change will make it functional. If the point is to leave it non-functional then a very obvious note in the readme would save folks time trying this out.

[bryanwb]

sorry, i should definitely put a loud warning in

On Wed, Mar 20, 2013 at 4:21 PM, Aaron Nichols [email protected]:

Good to know. For folks who try this with chef11 though this change will
make it functional. If the point is to leave it non-functional then a very
obvious note in the readme would save folks time trying this out.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/13#issuecomment-15182135
.

[adnichols]

It would be helpful to me and probably others to understand the issues with jmxtrans. I personally have had problems in the past but it seemed functional when I recently tried it. I didn't use it long enough to establish any sense for stability over time.

[richid]

+1, I'd like to know this as well.

[jhmartin]

Is this cookbook still considered deprecated? I don't see any warning in the README about its EOL, and its been a year since the last comment.

[bryanwb]

definitely deprecated as jmxtrans is pretty much unmaintained, will updated
the readme accordingly

use the JMX extension in collectd + graphite instead

On Mon, Jul 21, 2014 at 11:26 AM, Jason Martin [email protected]
wrote:

Is this cookbook still considered deprecated? I don't see any warning in
the README about its EOL, and its been a year since the last comment.

—
Reply to this email directly or view it on GitHub
#13 (comment).