-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor documentation changes #19
Comments
Point 1: Point 2: Point 3: If it is just the example If it is the methods |
About the automatic outlier detection, I would market it as metric-based outlier removal... Because the idea is that you test it just like the rest of the pipeline on workflows, so you can try a bunch of outliers methods and their combination and see if it improves the metric on the test set... But that is not even close to the common usage relying on statistics or domain-based reasons for the decision on whether to implement some form of outlier removal, I guess some documentation to make that point clear could help. I was trying to be greedy and keep both aspects on a single package. |
@topepo Only place with juice is now on tests |
The package looks good. Although I'm not a fan of automated outlier removals, I like what you've done.
In the docs, could you:
bake(rec, new_data = NULL)
instead ofjuice()
all_numeric_predictors()
instead ofall_numeric(), -all_outcomes()
The text was updated successfully, but these errors were encountered: