Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_current_expiration_date fails due to expiration on 2024-06-16 #36

Closed
matrss opened this issue Jun 13, 2024 · 8 comments · Fixed by #38
Closed

test_current_expiration_date fails due to expiration on 2024-06-16 #36

matrss opened this issue Jun 13, 2024 · 8 comments · Fixed by #38

Comments

@matrss
Copy link

matrss commented Jun 13, 2024

No description provided.

@ReimarBauer
Copy link
Contributor

Dear @brunobord

@matrss refers to a test we have in our MSS CI process for checking the expiration, Open-MSS/MSS#2406

We had a similiar problem also last year, see
#29

Could you do that fix again or let us know if we can help

best regards
Reimar

@matrss
Copy link
Author

matrss commented Jun 17, 2024

Actually, I was referring to a test of skyfield-data that was failing (while packaging it for nixpkgs), but there is another test in MSS now that is also failing for the same reason.

@ololyp
Copy link

ololyp commented Jun 20, 2024

Hello,
Not sure if it will fully address this issue, I've proposed PR #37 to update data file and expiration date in this repository.
This is my first contribution to a public repository, hope I've done nothing wrong for this PR.

@ReimarBauer
Copy link
Contributor

@ololyp thx for helping, I was also working on it and remembered not directly the make download. So I was a bit unsure on the xml date. Yours was a second opinion that it is the correct date. And make download was doing correctly ;)
I fixed the testing issue too.

@ReimarBauer
Copy link
Contributor

When it is uploaded to pypi the feedstock on conda-forge will update automatically. Or I do merge it there.

@brunobord brunobord mentioned this issue Jun 23, 2024
@brunobord
Copy link
Owner

I feel so dumb... I seem to be unable to upload the latest skyfield-data release. I'll keep on struggling, but I can't see the solution right now :(

@brunobord
Copy link
Owner

FINALLY! https://pypi.org/project/skyfield-data/6.0.0/

Happy upgrading!

@ReimarBauer
Copy link
Contributor

When touching this again, the table with the expiration dates needs a change too.

https://pypi.org/project/skyfield-data/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants