Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflect selected files in the address bar #26

Open
lishine opened this issue Apr 20, 2020 · 1 comment
Open

reflect selected files in the address bar #26

lishine opened this issue Apr 20, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@lishine
Copy link

lishine commented Apr 20, 2020

Is it possible to update the address bar with the navigated file?

@brumm
Copy link
Owner

brumm commented Apr 23, 2020

I'd love that! I tried this early on, but was running into some difficulties because github's pjax is reacting to url changes itself. So yeah, ideally the entire extension was truly router-driven and would write and respond to url changes. I'll tackle this at some point in the future, but I'd be thrilled if somone else could take a look at it ;)

@brumm brumm added enhancement New feature or request help wanted Extra attention is needed labels Apr 23, 2020
@brumm brumm changed the title Address bar reflect selected files in the address bar Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants