Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make robust to changes in {dplyr} #1

Open
brshallo opened this issue May 6, 2021 · 0 comments
Open

make robust to changes in {dplyr} #1

brshallo opened this issue May 6, 2021 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@brshallo
Copy link
Owner

brshallo commented May 6, 2021

Initial code for R/pairwise.R is copied from @carlomedina https://github.com/carlomedina/dplyr/blob/carlomedina/pairwise/R/across.R . Currently the approach modifies or copies in a lot of the backend / unexported functions from {dplyr}. If these change pairwiser() may break.

It may make sense to write such that only depends on exported functions from {dplyr} or in such a way that can feel good is not too fragile.

Also, with the current set-up, if we wanted to put the package on CRAN, we would likely need to copy the functions in from dplyr directly (rather than using dplyr:::fun().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant