Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not necessary to create a new iframe for each call. #19

Open
brucejo75 opened this issue Aug 31, 2017 · 0 comments
Open

Not necessary to create a new iframe for each call. #19

brucejo75 opened this issue Aug 31, 2017 · 0 comments

Comments

@brucejo75
Copy link

I have a project that makes many calls (some cases 100's) to vm.runInNewContext.

Each call to vm.runInNewContext incurs the creation and insertion of a new iframe.

This is not necessary, a single iframe can be cached, cleaned up after use and then re-used for subsequent calls to vm.runInNewContext.

I have a pr on the way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brucejo75