Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node core shim exporting json throws ParseError #46

Closed
jessetane opened this issue Jul 25, 2014 · 3 comments
Closed

node core shim exporting json throws ParseError #46

jessetane opened this issue Jul 25, 2014 · 3 comments

Comments

@jessetane
Copy link

require('constants') throws a ParseError when browserifying I suspect because the global transform that handles json files isn't getting applied:

https://github.com/substack/module-deps/blob/master/index.js#L292

should the transform be applied? or should constants-browserify not be exporting json? or am I doing it rong?

/cc @juliangruber

@ghost
Copy link

ghost commented Jul 25, 2014

This is certainly a bug! The reason was a bugfix to prevent user transforms from applying on internal modules because they aren't resolvable.

@ghost
Copy link

ghost commented Jul 25, 2014

Fixed in browserify itself in 5.9.0. module-deps only concerns itself with javascript, so browserify converts json files into javascript before handing off to module-deps properly now.

@ghost ghost closed this as completed Jul 25, 2014
@jessetane
Copy link
Author

cool, thanks!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant