Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for webworkers #36

Open
kumavis opened this issue Jan 19, 2014 · 2 comments · May be fixed by #37
Open

Support for webworkers #36

kumavis opened this issue Jan 19, 2014 · 2 comments · May be fixed by #37

Comments

@kumavis
Copy link

kumavis commented Jan 19, 2014

http-browserify assumes a normal browser window and not a worker, though http requests in a worker are legitimate

inside a webworker the global object is self not window
@kumavis kumavis linked a pull request Jan 19, 2014 that will close this issue
Open
lawnsea added a commit to TreehouseJS/jsdom that referenced this issue Aug 11, 2014
@lawnsea
upgrade browserify and work around browserify/http-browserify#36
a39dc15
lawnsea added a commit to TreehouseJS/jsdom that referenced this issue Aug 11, 2014
@lawnsea
upgrade browserify and work around browserify/http-browserify#36
11e2717
@domenic
Copy link

domenic commented Aug 19, 2014

+1

1 similar comment
@jayfunk
Copy link

jayfunk commented Sep 14, 2015

+1

@jayfunk jayfunk mentioned this issue Sep 14, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use 'global' instead of window. Fixes #36 kumavis/http-browserify
3 participants
@domenic @kumavis @jayfunk