From fda53423fff54268adea6532ce355da33e353faf Mon Sep 17 00:00:00 2001 From: Ferran Brosa Planella Date: Tue, 26 May 2020 10:46:44 +0200 Subject: [PATCH] added geometry option --- pybamm/models/full_battery_models/base_battery_model.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pybamm/models/full_battery_models/base_battery_model.py b/pybamm/models/full_battery_models/base_battery_model.py index a39e5f6c5c..df1249790d 100644 --- a/pybamm/models/full_battery_models/base_battery_model.py +++ b/pybamm/models/full_battery_models/base_battery_model.py @@ -181,6 +181,7 @@ def options(self, extra_options): "current collector": "uniform", "particle": "Fickian diffusion", "thermal": "isothermal", + "geometry": "arbitrary", "external submodels": [], "sei": None, } @@ -273,6 +274,10 @@ def options(self, extra_options): raise pybamm.OptionError( "Unknown thermal model '{}'".format(options["thermal"]) ) + if options["geometry"] not in ["arbitrary", "pouch"]: + raise pybamm.OptionError( + "Unknown geometry '{}'".format(options["geometry"]) + ) if options["sei"] not in [ None, "constant", @@ -548,7 +553,7 @@ def set_thermal_submodel(self): elif self.options["thermal"] == "lumped": thermal_submodel = pybamm.thermal.Lumped( - self.param, self.options["dimensionality"] + self.param, self.options["dimensionality"], self.options["geometry"] ) elif self.options["thermal"] == "x-lumped":