Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request duration? #88

Open
jqdurham opened this issue Feb 2, 2016 · 2 comments
Open

Add request duration? #88

jqdurham opened this issue Feb 2, 2016 · 2 comments

Comments

@jqdurham
Copy link

jqdurham commented Feb 2, 2016

We'd like to monitor the performance of our API and hoped that Airborne might allow us to do this natively. It would be nice to have a warning (just a PUTS with the time and warning message) and also the ability to evaluate the request time to trigger a failure.

@bafio
Copy link

bafio commented Nov 21, 2016

it should be taken care with #119

@rdalverny
Copy link
Contributor

RestClient incoming 2.1 (still a release candidate) introduces a duration attribute to responses.

This allows to add an expectation on the response time: expect(response.duration).to be < 1.0 for instance. This complements the options introduced by #119 I think.

Two questions:

  • it will have to wait at least for the final 2.1 release, but apart from that, would it be ok to upgrade the dependency version right up to 2.1 or is there a requirement to keep an older version? (tests are still green so far)
  • I'm not sure about a good expectation name: expect_worst_latency(value)? other?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants