Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only "Mouse Click", "Scroll Page / Element" and "Omnibar" functionality working #2149

Closed
matko031 opened this issue Sep 16, 2024 · 27 comments
Closed

Comments

@matko031
Copy link

Error details

SurfingKeys: 1.17.0

Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36

URL: everywhere

Context

I just installed surfingkeys in brave and most mappings don't seem to work. The mappings from groups "Mouse Click", "Scroll Page / Element" and "Omnibar" are working ok, but all the others not. For instance switching tabs with E/R or choosing a tab with T has no effect whatsoever. I tried this in brave, chrome, and chromimum and in all three cases it's the same issue. In Firefox everything works fine.

@brookhong
Copy link
Owner

1.17.0 is released for MV3 upgrade, I works well in my Chrome 128.0.6613.138. Any errors from console(Inspect tool)?

@PhilStar101
Copy link

@brookhong After todays update alt+s to toggle surfing keys stop working. Chrome 128.0.6613.138, no console errors or something

@matko031
Copy link
Author

I also have 128.0.6613.138 chromium version and there are no errors in the console

@dmfay
Copy link
Contributor

dmfay commented Sep 16, 2024

I noticed the extension settings seem no longer persistent -- the "advanced mode" checkbox and settings path both clear once I leave the page.

@rosshadden
Copy link
Contributor

Starting today I get an error that api.Hints.setCharacters is not a function (on 1.17.0).

@aka-phrankie
Copy link

I found that my custom configuration could not be saved, and the system's built-in button X to close the page could not be used.

I would like to ask if this is a function that cannot be achieved by manifest v3 or a bug.

@brookhong
Copy link
Owner

@rosshadden Yes, that function is missed, will be fixed soon. So you can load your config file, right?

@rosshadden
Copy link
Contributor

Yeah I just commented out the line for now 👍.

@desgua
Copy link

desgua commented Sep 16, 2024

I can't change any settings nor can I load my old settings. I'm using Chrome 128.0.6613.137 (Official Build) (64-bit Linux) and SurfingKeys 1.17.0.

@desgua
Copy link

desgua commented Sep 16, 2024

Is there a way to downgrade the extension?

@frankzvitale
Copy link

frankzvitale commented Sep 16, 2024

@brookhong After todays update alt+s to toggle surfing keys stop working.

Also here to report alt+s not working; previously toggled websites are now active and I cannot re-toggle anything. Passthrough mode continues to work as a temporary workaround. Chrome 128.0.6613.138 (Official Build) (64-bit) Windows 11, SurfingKeys 1.17.0.

@desgua
Copy link

desgua commented Sep 16, 2024

I tested SurfingKeys 1.17.0 on Chromium Version 128.0.6613.137 (Official Build) built on Debian GNU/Linux 12 (bookworm) (64-bit). Editing or loading settings are also broken. No additional info is given on the console.

@desgua
Copy link

desgua commented Sep 16, 2024

This is how the settings page is looking since the 1.17.0 update.
screenshot_2024_09_16_16_04_23

@thiendiahui
Copy link

[SurfingKeys] Error found in settings: TypeError: api.Hints.setCharacters is not a function

@orangeMangoDimz
Copy link

Yes, I am facing many of the same issues, like the “OG” shortcut to search through google is also not working. Even my custom configuration in advance mode is also missing.

image

@brookhong
Copy link
Owner

@desgua @orangeMangoDimz Is there any error from console(Inspect tool) for the options page?

@brookhong
Copy link
Owner

[SurfingKeys] Error found in settings: TypeError: api.Hints.setCharacters is not a function

Known issue, will be fixed soon.

@TanukiLoop
Copy link

Error details

SurfingKeys: 1.17.0

Browser: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36

URL: everywhere

Context

I just installed surfingkeys in brave and most mappings don't seem to work. The mappings from groups "Mouse Click", "Scroll Page / Element" and "Omnibar" are working ok, but all the others not. For instance switching tabs with E/R or choosing a tab with T has no effect whatsoever. I tried this in brave, chrome, and chromimum and in all three cases it's the same issue. In Firefox everything works fine.

Found my way here because of the same issue/experience. Was surprised that the previous/next tab keys stopped functioning as before despite running the default settings and seeing no errors in the console.

Thanks for the firefox reminder.

Browser: Version 1.69.168 Chromium: 128.0.6613.138 (Official Build) (64-bit)

@dmfay
Copy link
Contributor

dmfay commented Sep 17, 2024

@desgua @orangeMangoDimz Is there any error from console(Inspect tool) for the options page?

not on load but when I try to save the path to my config script after ticking the advanced-user checkbox I get this:

options.js:1 Uncaught TypeError: Cannot read properties of null (reading 'getValue')
    at HTMLInputElement.A (options.js:1:3849)

this points to line 2 in this minified function:

    function A() {
        var t = u.getValue()
          , o = E(w.value.trim());
        o.length && o !== x ? e("loadSettingsFromUrl", {
            url: o
        }, (function(e) {
            l(e.status + " to load settings from " + o, 5e3),
            K(e),
            e.snippets && e.snippets.length ? (x = o,
            u.setValue(e.snippets, -1)) : "" === t && u.setValue(P, -1)
        }
        )) : (e("updateSettings", {
            settings: {
                snippets: t,
                localPath: E(w.value)
            }
        }),
        l("Settings saved", 1e3))
    }

@orangeMangoDimz
Copy link

orangeMangoDimz commented Sep 17, 2024

@desgua @orangeMangoDimz Is there any error from console(Inspect tool) for the options page?

Nope

image

Oh wait, when I pressed the save button, an error appeared in my console:

options.js:1 Uncaught TypeError: Cannot read properties of null (reading 'getValue')
    at HTMLInputElement.A (options.js:1:3849)

@brookhong
Copy link
Owner

Please go to chrome://extensions/, click on the link to service worker, then check if there is any error from the popup console.
image

@dmfay
Copy link
Contributor

dmfay commented Sep 17, 2024

Please go to chrome://extensions/, click on the link to service worker, then check if there is any error from the popup console. image

The service worker shows (inactive) and clicking the link doesn't do anything for me. I'm using Vivaldi but it does support ManifestV3 afaik

@j8s0n
Copy link

j8s0n commented Sep 17, 2024

I'm experiencing this on one of my Arch machines running Brave. I like Brave, but I can't use a browser without SurfingKeys, so I might have to try Firefox.

@brookhong
Copy link
Owner

brookhong commented Sep 17, 2024

Please go to chrome://extensions/, click on the link to service worker, then check if there is any error from the popup console. image

The service worker shows (inactive) and clicking the link doesn't do anything for me. I'm using Vivaldi but it does support ManifestV3 afaik

That might be the problem. You can reload the extension and see if the link will be activated, then click the link to open the console and save your config file path(or maybe just open the options page) to check the errors from the console.

@matko031
Copy link
Author

Please go to chrome://extensions/, click on the link to service worker, then check if there is any error from the popup console. image

The service worker shows (inactive) and clicking the link doesn't do anything for me. I'm using Vivaldi but it does support ManifestV3 afaik

I had the same issue and after removing and re-adding the extension service worker is working as well as all the functionality

@matko031
Copy link
Author

Just an additional clarification, I just installed the extension in another brave profile and it did not work again. I tried removing it and adding it and still nothing. For some reason, I have to click on service worker (inactive) (where nothing seems to happen) and then after removing and adding it again it works fine.

@brookhong
Copy link
Owner

Wow, thanks @matko031. Looks like there are some incompatible settings left from previous version, so a workable solution would be removing and adding the extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests