Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better solution for per-platform support #5

Open
brodycj opened this issue Apr 18, 2019 · 0 comments
Open

Better solution for per-platform support #5

brodycj opened this issue Apr 18, 2019 · 0 comments

Comments

@brodycj
Copy link
Owner

brodycj commented Apr 18, 2019

The existing solution needs one JavaScript file per platform, as described in lelandrichardson/react-primitives#136 (comment).

I think a better solution would be to check for absence vs presence of non-React Native navigator variable as suggested in necolas/react-native-web#1146 (comment).

I think this idea should both alleviate per-platform maintenance need and avoid some potentially risky assumptions about the build tooling used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant