Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fs.copyFile() api in node 8.5+ #34

Open
kanongil opened this issue Sep 21, 2017 · 2 comments · May be fixed by #41
Open

Use fs.copyFile() api in node 8.5+ #34

kanongil opened this issue Sep 21, 2017 · 2 comments · May be fixed by #41

Comments

@kanongil
Copy link

See https://nodejs.org/api/fs.html#fs_fs_copyfile_src_dest_flags_callback

The new copyFile implementation is based on uv_fs_copyfile(), and uses much faster native file copying api's, where available. See nodejs/node#14906 (comment).

@stefanpenner stefanpenner linked a pull request Jul 27, 2018 that will close this issue
@stefanpenner
Copy link
Contributor

stefanpenner commented Jul 27, 2018

@kanongil good idea, especially now that node 8.5 is more utilized. I have a PR open -> #41

I don't want to land without thorough windows testing, so if you have some cycles I would love feedback on testing the PR

@stefanpenner
Copy link
Contributor

@kanongil I'll need to test this again, last time I tried, it was not at all faster for smallish files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants