You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Throughout the v03 pipeline code we rely heavily on the CONFIG dictionary defined in v03_pipeline/lib/reference_data/config.py, which holds external dataset configurations.
Refactor this dict into something more object oriented (like enums or python dataclasses) and replace all the references to the dict, (including the many mock config dicts in tests, like this), to make the code cleaner and more maintainable. (One issue with the dict is that we have no way to enforce requirements like if one key is present, another must also be.)
This is also a good time to add ReferenceGenome as an attribute of the dataset (suggested in a code review here).
The text was updated successfully, but these errors were encountered:
Throughout the v03 pipeline code we rely heavily on the CONFIG dictionary defined in v03_pipeline/lib/reference_data/config.py, which holds external dataset configurations.
Refactor this dict into something more object oriented (like enums or python dataclasses) and replace all the references to the dict, (including the many mock config dicts in tests, like this), to make the code cleaner and more maintainable. (One issue with the dict is that we have no way to enforce requirements like if one key is present, another must also be.)
This is also a good time to add
ReferenceGenome
as an attribute of the dataset (suggested in a code review here).The text was updated successfully, but these errors were encountered: