Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor dataset CONFIG dict into models #772

Open
jklugherz opened this issue Apr 26, 2024 · 0 comments
Open

Refactor dataset CONFIG dict into models #772

jklugherz opened this issue Apr 26, 2024 · 0 comments

Comments

@jklugherz
Copy link
Contributor

jklugherz commented Apr 26, 2024

Throughout the v03 pipeline code we rely heavily on the CONFIG dictionary defined in v03_pipeline/lib/reference_data/config.py, which holds external dataset configurations.

Refactor this dict into something more object oriented (like enums or python dataclasses) and replace all the references to the dict, (including the many mock config dicts in tests, like this), to make the code cleaner and more maintainable. (One issue with the dict is that we have no way to enforce requirements like if one key is present, another must also be.)

This is also a good time to add ReferenceGenome as an attribute of the dataset (suggested in a code review here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant