Updating htsjdk to 2.19.0 #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updating htsjdk from 2.18.2 -> 2.19.0 * Fix SamFormatConverter test * Replacing deprecated TestUtils method
lbergelson
force-pushed
the
lb_update_htsjdk
branch
from
a7e539d to
2193c0a
Compare
lbergelson
commented
Mar 18, 2019
| * @param referenceSequence the reference sequence to use, necessary when reading/writing cram | ||
| * @param createIndex whether or not an index should be written alongside the output file | ||
| */ | ||
| public static void convert(final File input, final File output, final File referenceSequence, final Boolean createIndex) { |
There was a problem hiding this comment.
I extracted the guts of this tool into a public method so it could be tested more sanely.
| @@ -34,63 +36,47 @@ | |||
| import static org.testng.Assert.assertEquals; | |||
| import static org.testng.Assert.assertTrue; | |||
|
|
|||
| public class SamFileConverterTest { | |||
| public class SamFormatConverterTest { | |||
There was a problem hiding this comment.
Renamed the test so it matched the tool name.
| public class | ||
| SamFormatConverter extends CommandLineProgram { | ||
|
|
||
| private static final String PROGRAM_VERSION = "1.0"; |
yfarjoun
approved these changes
Mar 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist (never delete this)
Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.
Content
Review
For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests