Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure 1 discussions #23

Open
gwaybio opened this issue Feb 18, 2021 · 2 comments
Open

Figure 1 discussions #23

gwaybio opened this issue Feb 18, 2021 · 2 comments

Comments

@gwaybio
Copy link
Member

gwaybio commented Feb 18, 2021

In #18 I added the first draft of figure 1, lets use this issue to discuss.

figure1

@AnneCarpenter
Copy link

For part a, are replicates replicates or are they different guides? Or it depends on whether you're calculating the Grit of a guide vs the Grit of a gene?

Is it intentional that the lines connect the target to each control (vs connecting each replicate to each control)?

I agree with the concern mentioned today about using median vs mean to insulate a bit against cases where a single guide is 'bad' aka ineffective. OTOH, one would want a case of 3 great guides to yield a higher score than 2 great and one terrible guide, so 🤷

@gwaybio
Copy link
Member Author

gwaybio commented Feb 18, 2021

For part a, are replicates replicates or are they different guides? Or it depends on whether you're calculating the Grit of a guide vs the Grit of a gene?

Yes, good point. I use "replicate" here for convenience in understanding. It really is "group". "replicate" is a kind of "group". So, you can calculate grit w.r.t. replicates (aka same guide different well) or w.r.t. to the gene group (aka all wells of different guides targeting the same gene).

The fact that the software handles this seamlessly is another benefit :)

Is it intentional that the lines connect the target to each control (vs connecting each replicate to each control)?

Yep! Every target gets a grit score. In calculating the target's grit score, we never perform calculations directly between the replicate profiles and the controls. It truly is the target's reproducibility within the group with respect to controls.

I agree with the concern mentioned today about using median vs mean to insulate a bit against cases where a single guide is 'bad' aka ineffective. OTOH, one would want a case of 3 great guides to yield a higher score than 2 great and one terrible guide, so 🤷

Yeah... exactly. Also, at least in the Cell Health data, and empirically, it makes very little difference. Spearman correlations ~.98 (cell 7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants