Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectVariants use a GATKPathSpecifier for output #5870

Merged
merged 1 commit into from
Apr 9, 2019

Conversation

jean-philippe-martin
Copy link
Contributor

Instead of a String previously.

Tested like this:

$ ./gatk SelectVariants \
--variant src/test/resources/large/VQSR/dbsnp_132_b37.leftAligned.20.1M-10M.vcf \
--select-random-fraction 0.01 \
--output gs://$BUCKET/variants.vcf

and

$ ./gatk SelectVariants \
--variant src/test/resources/large/VQSR/dbsnp_132_b37.leftAligned.20.1M-10M.vcf \
--select-random-fraction 0.01 \
--output /tmp/variants.vcf

If this works, the plan is to change all tools to use this format, so they can all write VCF output to Google Cloud Storage.

Instead of a String previously.
@codecov-io
Copy link

codecov-io commented Apr 8, 2019

Codecov Report

Merging #5870 into master will increase coverage by 0.002%.
The diff coverage is 100%.

@@              Coverage Diff               @@
##             master     #5870       +/-   ##
==============================================
+ Coverage     86.84%   86.842%   +0.002%     
  Complexity    32274     32274               
==============================================
  Files          1987      1987               
  Lines        149001    149001               
  Branches      16469     16469               
==============================================
+ Hits         129392    129395        +3     
+ Misses        13596     13594        -2     
+ Partials       6013      6012        -1
Impacted Files Coverage Δ Complexity Δ
...org/broadinstitute/hellbender/engine/GATKTool.java 91.204% <ø> (ø) 102 <0> (ø) ⬇️
...der/tools/walkers/variantutils/SelectVariants.java 80.914% <100%> (ø) 131 <0> (ø) ⬇️
...e/hellbender/engine/spark/SparkContextFactory.java 71.233% <0%> (-2.74%) 11% <0%> (ø)
...nder/utils/runtime/StreamingProcessController.java 67.773% <0%> (+0.474%) 33% <0%> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 90% <0%> (+10%) 3% <0%> (ø) ⬇️
...ithwaterman/SmithWatermanIntelAlignerUnitTest.java 90% <0%> (+30%) 2% <0%> (ø) ⬇️

@droazen droazen requested a review from cmnbroad April 9, 2019 15:07
Copy link
Collaborator

@cmnbroad cmnbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already have the bucket test for this code path from the last PR, looks good.

@cmnbroad cmnbroad merged commit 32e97c5 into master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants