Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadsPipelineSpark fails with "Interval not within the bounds of a contig" #5645

Merged
merged 1 commit into from
Feb 5, 2019

Conversation

tomwhite
Copy link
Contributor

@tomwhite tomwhite commented Feb 5, 2019

Fixes #5644.

The issue was that different sequence dictionaries were being used.

@codecov-io
Copy link

codecov-io commented Feb 5, 2019

Codecov Report

Merging #5645 into master will decrease coverage by 0.594%.
The diff coverage is 0%.

@@               Coverage Diff               @@
##              master     #5645       +/-   ##
===============================================
- Coverage     87.035%   86.441%   -0.594%     
- Complexity     31726     31896      +170     
===============================================
  Files           1943      1943               
  Lines         146193    148531     +2338     
  Branches       16141     16607      +466     
===============================================
+ Hits          127239    128391     +1152     
- Misses         13067     14170     +1103     
- Partials        5887      5970       +83
Impacted Files Coverage Δ Complexity Δ
...nder/tools/spark/pipelines/ReadsPipelineSpark.java 90.741% <0%> (ø) 13 <0> (ø) ⬇️
...ols/funcotator/FuncotatorDataSourceDownloader.java 37.008% <0%> (-29.189%) 9% <0%> (-5%)
...llbender/utils/reference/FastaReferenceWriter.java 64.593% <0%> (-27.872%) 48% <0%> (-3%)
...ces/gencode/GencodeFuncotationFactoryUnitTest.java 68.254% <0%> (-25.784%) 35% <0%> (-32%)
.../utils/reference/FastaReferenceWriterUnitTest.java 62.443% <0%> (-22.696%) 33% <0%> (-37%)
...ellbender/tools/walkers/vqsr/CNNScoreVariants.java 58.387% <0%> (-22.057%) 33% <0%> (-12%)
.../walkers/vqsr/CNNScoreVariantsIntegrationTest.java 78.534% <0%> (-21.466%) 8% <0%> (-5%)
...ownsampling/ReadsDownsamplingIteratorUnitTest.java 51.724% <0%> (-20.407%) 7% <0%> (-4%)
...ender/utils/downsampling/ReservoirDownsampler.java 86.301% <0%> (-13.699%) 33% <0%> (+6%)
...ils/downsampling/ReservoirDownsamplerUnitTest.java 77.273% <0%> (-10.356%) 13% <0%> (ø)
... and 18 more

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@lbergelson lbergelson merged commit a3abff7 into master Feb 5, 2019
@lbergelson lbergelson deleted the tw_reads_pipeline_spark_interval_contig_bug branch February 5, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants