Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made Mutect2 read position filter default much less stringent #5487

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

davidbenjamin
Copy link
Contributor

@takutosato I was checking the filter analysis outputs of every M2 validation and this filter hurts much, much more than it helps, probably because other developments have made it less necessary. Let's essentially turn it off by default.

@davidbenjamin davidbenjamin merged commit 6096004 into master Dec 5, 2018
@davidbenjamin davidbenjamin deleted the db_relax_read_pos branch December 5, 2018 22:07
@xiucz
Copy link

xiucz commented Dec 6, 2018

Hi,
Sorry to jump in, I find the default value of --min-median-read-position is already 5 in the doc. I am confused why the code's value and the value in the doc are out of sync, it seems that the doc's value was set ahead ?

Have I misunderstood some ? Thanks for your reply.

@davidbenjamin
Copy link
Contributor Author

@xiucz it was 5; this PR sets it to 1, which is essentially "off." We are gradually converging on a more holistic filtering approach that directly evaluates the possibility of mapping errors, and as we do so these proxies for mapping error outlive their usefulness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants