Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS-857. Change default behavior of GvsBulkIngestGenomes.wdl to drop state NONE. #8550

Merged
merged 4 commits into from
Oct 12, 2023
Merged

VS-857. Change default behavior of GvsBulkIngestGenomes.wdl to drop state NONE. #8550

merged 4 commits into from
Oct 12, 2023

Conversation

gbggrant
Copy link
Collaborator

@gbggrant gbggrant commented Oct 11, 2023 •
edited
Loading

VS-857.
Change default behavior of GvsBulkIngestGenomes.wdl BACK to not dropping GQ0 ref blocks.
Updated AoU documentation to say we need to do it there (as an input).

Passing Integration Test here

@gbggrant
VS-857. Change default behavior of GvsBulkIngestGenomes.wdl BACK to n…
2291a13 
…ot dropping GQ0 ref blocks.

Updated AoU documentation to say we need to do it there (as an input).
koncheto-broad
koncheto-broad approved these changes Oct 11, 2023
View reviewed changes
Copy link

@koncheto-broad koncheto-broad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mcovarr
mcovarr reviewed Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the cost expectations need to be changed back to whatever they were before for integration?

@mcovarr
Copy link
Collaborator

mcovarr commented Oct 11, 2023

And on that note... integration run?

mcovarr
mcovarr approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I just remembered you reminded me in standup that these drop states are overridden by GvsJointVariantCalling.wdl as well as the integration tests so never mind about the integration run.

@gbggrant
Copy link
Collaborator Author

I kicked off an integration test run this morning. I don't expect the results to change (since the integration tests all set the drop_state themselves). But I've been burned before!

@gbggrant gbggrant merged commit ceadce0 into ah_var_store Oct 12, 2023
@gbggrant gbggrant deleted the gg_VS-857_MakeDropStateNoneTheDefaultInBulk branch October 12, 2023 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koncheto-broad koncheto-broad koncheto-broad approved these changes

@mcovarr mcovarr mcovarr approved these changes

@rsasch rsasch Awaiting requested review from rsasch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbggrant @mcovarr @koncheto-broad