Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadPosRankSumTest doesn't work for two deletions with one base in between #5492

Closed
davidbenjamin opened this issue Dec 7, 2018 · 1 comment · Fixed by #6485
Closed

ReadPosRankSumTest doesn't work for two deletions with one base in between #5492

davidbenjamin opened this issue Dec 7, 2018 · 1 comment · Fixed by #6485
Assignees

Comments

@davidbenjamin
Copy link
Contributor

davidbenjamin commented Dec 7, 2018

When ReadPosRankSumTest.getReadPosition encounters the second of two deletions with two bases in between it hits the following code:

if ( AlignmentUtils.isInsideDeletion(read.getCigar(), offset) ) {
            return OptionalDouble.of(INVALID_ELEMENT_FROM_READ);
}

which returns negative infinity. Those with TCGA access can reproduce the issue by running on the TCGA exome pair ESCA-IG-A3YB-TP-NB at 15:34525804-34525810.

@davidbenjamin
Copy link
Contributor Author

You can consider this fixed if it passes a simple unit test where you run ReadPosRankSumTest.getReadPosition on a few artificial read of the form <short ref match of 1-5 or so bases>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant