Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate VCFOutputRenderer to see if it can be made to behave more like MafOutputRenderer #5240

Open
jonn-smith opened this issue Sep 28, 2018 · 0 comments

Comments

@jonn-smith
Copy link
Collaborator

Feature request

Tool(s) or class(es) involved

Funcotator, MafOutputRenderer, VcfOutputRenderer

Description

For VCFs, we render each funcotation separately, then concatenate strings. This approach has the drawback of being less flexible in terms of ordering the fields (and setting up aliases), but that has not mattered yet. Regardless, it means that all string operations (e.g. excluding fields and sanitizing values) must be in the same method (in this case renderSanitizedFuncotationForVcf) and that method must work on a funcotation.

For MAFs, we flatten out the funcotations and put the fields into a giant map. Then we do the changes to field names and values on that map. But by the time I want to exclude fields and sanitize, the map is already made, so we do not render individual funcotations. Therefore no need for a renderSantiziedFuncotationForMaf.

We should investigate how easy it would be to generalize an output renderer to use the map convention like in MafOutputRenderer so we can bubble up that functionality. Since there are only 2 output types now, it might be best to do it before we get more of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant