You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Minor things that should be fixed in CNNScoreVariants:
the header should include the lines returned from getDefaultToolVCFHeaderLines
the code currently (unnecessarily?) adds standard VQSR header lines via addVQSRStandardHeaderLines
we should consider writing the reads data as separate lines in the FIFO for the 2d case to eliminate the need to create and then parse very long lines in python to find variant and read boundaries. longer term we may want to use a more structured format such as protocol buffers
@ldgauthier@lucidtronix I'm updating this with a proposed list of CNNScoreVariants issues I think need to be resolved before we can remove the @Beta tag (actually is currently marked @Experimental). Let me know what you think:
factor python args handling (minimally factor out the inference args)
there is only one 2D test, which I think has no reads overlapping any of the variants
we should add a test that specifies one or more intervals
the tool currently adds standard VQSR header lines via addVQSRStandardHeaderLines, which is unnecssary
integrate read downsampling
determine/handle the failure mode when the user supplies a mix (of mismatched) 1D/2D arch and weights inputs
Other (not necessarily blockers):
establish all defaults (weights/arch/etc) in Java code
default arch is 1D - should this change to 2D ?
see if we can remove the artificially small inference/batch sizes (1) used in the tests. I think we added these due to timeouts which should no longer be an issue.
remove the newExpectations code paths in integration tests
Minor things that should be fixed in CNNScoreVariants:
The text was updated successfully, but these errors were encountered: