Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VariantAnnotator, extract a common interface between readsLikelihoods and UnfilledReadsLikelihoods. #4462

Closed
jamesemery opened this issue Feb 26, 2018 · 1 comment
Closed

VariantAnnotator, extract a common interface between readsLikelihoods and UnfilledReadsLikelihoods. #4462

jamesemery opened this issue Feb 26, 2018 · 1 comment
Assignees
@jamesemery

Comments

@jamesemery
Copy link
Collaborator

As part of the implementation of VariantAnnotator, to avoid significant changes to the annotation interfaces a subclass of ReadLikelihoods was made to support partial data that was backed up by read pileups. Unfortunately since functionality is entangled with its superclass, this subclass is going to be subject to issues as more likelihoods functionality is added. A common interface between the two objects along the lines of a "ReadEvidence" object would help alleviate these problems.
Related to #4450, #3803
@jamesemery jamesemery self-assigned this Feb 26, 2018
@davidbenjamin
Copy link
Contributor

Closed by #6172.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesemery jamesemery

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidbenjamin @jamesemery