Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get NIO writing working for both bams and vcfs in walkers #2422

Open
droazen opened this issue Feb 23, 2017 · 3 comments
Open

Get NIO writing working for both bams and vcfs in walkers #2422

droazen opened this issue Feb 23, 2017 · 3 comments
Assignees
Milestone

Comments

@droazen
Copy link
Contributor

droazen commented Feb 23, 2017

Writing output via NIO is currently broken, as reported by @jean-philippe-martin:

 /home/jpmartin/build/install/gatk/bin/gatk PrintReads -I inputs/CEUTrio.HiSeq.WEx.b37.NA12892.bam -L 10:1000000-2000000 -O gs://jpmartin/staging/out_tmp.bam
htsjdk.samtools.util.RuntimeIOException: Error opening file: /home/jpmartin/gs:/jpmartin/staging/out_tmp.bam
        at htsjdk.samtools.SAMFileWriterFactory.makeBAMWriter(SAMFileWriterFactory.java:246)

Now that the read support is in good shape, let's get the writing end working -- should hopefully be an easy fix.

@droazen
Copy link
Contributor Author

droazen commented Feb 23, 2017

For @jean-philippe-martin

@droazen droazen added this to the beta milestone Feb 23, 2017
@droazen droazen added the NIO label Mar 22, 2017
@droazen droazen modified the milestones: 4.0 release, beta May 30, 2017
@droazen droazen removed the bug label May 30, 2017
@jean-philippe-martin
Copy link
Contributor

GCS output works now for PrintReads. Next step is to switch all the other walkers to use the Path overload, too.

@jean-philippe-martin
Copy link
Contributor

For what it's worth, this works but I should improve the error message. If you don't have the right permissions, currently you get an error that's something like this:

htsjdk.samtools.util.RuntimeIOException: Error opening file: file:///home/jpmartin//gatk/gs:/bobs-bucket-you-cant-write-to/test-output/printtogcs.bam

This is both

  • confusing: it makes it look like the path is wrong even though the code actually tried the correct path
  • improvable: it'd be nice if we gave the reason there was an error (403 Forbidden: user jpmartin doesn't have write access)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants