-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce an import style convention #138
Comments
I agree w/ Adam. Full names are more specific, avoid namespace collisions, and (depending on package sizes) could reduce compile time a bit (maybe insignificant for us though). |
I don't feel strongly either way. I'm fine with full imports. |
By default it looks like intellij switches to import a package with * when 5 or more classes from the same package are imported. You can change it to an arbitrary number in preference->editor->codes style-> java->imports Do we want to set it higher? The only issue I see is that 50% of our code is going to be import java.utils lines. You can also specify specific packages to import with *, we could import all on java standard library and import specifically when using external libraries. |
I vote for collapsing after 5 or more -- full imports would clutter the diffs during code review. Also, gains in compile time are likely to not be noticeable. |
Brain not fully working when I wrote the above -- of course both options clutter the diffs in different ways :) |
This is done -- we've standardized on collapsing after 5 or more. |
without an import style convention, many commits include edits that change full imports to star (*) back and forth.
I vote for full name imports everywhere, it's easy to collapse them in the editor.
The text was updated successfully, but these errors were encountered: