From 45473210c76300f61109ffebee0eb538d2ba158d Mon Sep 17 00:00:00 2001 From: Samuel Lee Date: Wed, 4 Aug 2021 15:19:10 -0400 Subject: [PATCH] Added a test case to guard against possible overflow. --- .../tools/walkers/annotator/ExcessHetUnitTest.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/test/java/org/broadinstitute/hellbender/tools/walkers/annotator/ExcessHetUnitTest.java b/src/test/java/org/broadinstitute/hellbender/tools/walkers/annotator/ExcessHetUnitTest.java index db71e9b2289..d858d6c12c3 100644 --- a/src/test/java/org/broadinstitute/hellbender/tools/walkers/annotator/ExcessHetUnitTest.java +++ b/src/test/java/org/broadinstitute/hellbender/tools/walkers/annotator/ExcessHetUnitTest.java @@ -266,7 +266,10 @@ public Object[][] counts() { {552, 438, 207, 0.9367121245319978}, {886, 812, 216, 0.1488013326311986}, {537, 845, 72, 0.14763417247333427}, - {8700, 3186, 5918, 0.46111947799744585} + {8700, 3186, 5918, 0.46111947799744585}, + // for guarding against the introduction of overflow? this implementation doesn't seem to have issues, + // but see https://github.com/samtools/htsjdk/issues/44 and https://github.com/samtools/htsjdk/pull/70 + {250000, 500000, 250000, 0.9999999960917298} }; }