Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant GetPed task in GatherBatchEvidence.CNMOPS #591

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

kirtanav98
Copy link
Contributor

The GetPed task should be removed was removed from CNMOPS now that SubsetPedFile is run earlier in the workflow for GatherBatchEvidence. This was validated using womtool and successfully tested on the 1-kg reference data using cromwell.

… now that SubsetPedPedFile is run earlier in the workflow.
Copy link
Collaborator

@epiercehoffman epiercehoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for removing this redundant code - it will reduce the size of the code base that we need to maintain and prevent wasting time on unnecessary compute.

@kirtanav98 kirtanav98 merged commit 3346bd1 into main Aug 28, 2023
@kirtanav98 kirtanav98 deleted the kv_remove_GetPed branch August 28, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants