Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation of input 'File' that is a folder #3785

Closed
EvanTheB opened this issue Jun 15, 2018 · 5 comments
Closed

Localisation of input 'File' that is a folder #3785

EvanTheB opened this issue Jun 15, 2018 · 5 comments

Comments

@EvanTheB
Copy link
Contributor

I have a task with an input 'File' (WDL concept) that is actually a folder. I did not know what would happen, as I could not find explanation of the concept in either wdl or cromwell docs.

For the 'File's that are actually files, cromwell reports Localisation via hard-link has failed ... invalid cross device link as expected (different disks), and then seems to successfully soft-link (as expected). For the folder, the same hard link error appears, but then there is no soft link error, and the folder is (recursively) copied. The folder hard link would also fail due to folders not being hard-linkable. But the soft-link should probably succeed.

I am running an SGE backend, with no modification of the 'localisation' settings https://cromwell.readthedocs.io/en/latest/backends/HPC/#shared-filesystem

What is the expected behaviour? Should I avoid using folders for WDL 'File's? Any advice would be appreciated.

Thanks

@EvanTheB
Copy link
Contributor Author

openwdl/wdl#173

@Adrien-Evo
Copy link

I'm having the same kind of issues with cromwell 32. Hard link are failing but symbolic link are working for the first task.
Then the task fail due to, again hard link not permitted , then due to soft link not permitted due to too many level of symbolic links.

@geoffjentry
Copy link
Contributor

@EvanTheB Yeah, File in WDL is not supposed to reference a directory (as you noted in your followup, that's a whole separate topic). It manages to work-ish by happenstance on shared filesystem backends, as you discovered - we came across that a little while back.

I'd call it one of those things where if it Works For You then knock yourself out but keep in mind that it's not supported behavior and if your WDL relies on it they'll not be portable in cloud environments.

@EvanTheB
Copy link
Contributor Author

EvanTheB commented Jul 6, 2018

OK thanks for the clarification @geoffjentry , I am happy, I guess it is up to you if this should be in the docs or be a warning or have different behaviour.

@EvanTheB EvanTheB closed this as completed Jul 6, 2018
@geoffjentry
Copy link
Contributor

@EvanTheB It's a good point that we should slip a warning in the docs somewhere as this isn't the first time it has come up (or, alternatively, push the OpenWDL group to ratify a directory type!)

@ruchim @cjllanwarne Any thoughts on if we should put this somewhere and if so where? I could see it being part of the WDL docs maybe? Now that I say that I think the Cromwell docs are more appropriate but I have no idea which section would be most appropriate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants