fix(repo): Guard against an undefined player (#67)

* Guard against an undefined player * Added test for undefined player in detachHandlersFromPlayer
bringking · Oct 20, 2017 · 904e3c2 · 904e3c2
1 parent 1d3b1df
commit 904e3c2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/mixins/playable.js b/src/mixins/playable.js
@@ -12,8 +12,10 @@ export default {
     player.oncancel = props.onCancel;
   },
   detachHandlersFromPlayer(player) {
-    player.onfinish = null;
-    player.oncancel = null;
+    if (player) {
+      player.onfinish = null;
+      player.oncancel = null;
+    }
   },
   notifyHandlers(event) {
     const { player } = this.state;

diff --git a/src/mixins/playable.test.js b/src/mixins/playable.test.js
@@ -40,6 +40,10 @@ describe('playable', () => {
       expect(player.onfinish).toBe(null);
       expect(player.oncancel).toBe(null);
     });
+
+    it('will not throw exception on undefined player', () => {
+      playable.detachHandlersFromPlayer(undefined);
+    });
   });
 
   describe('notifyHandlers', () => {