Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from fs (pyfilesystem) to fsspec #65

Closed
michaelweinold opened this issue May 20, 2024 · 3 comments
Closed

Move from fs (pyfilesystem) to fsspec #65

michaelweinold opened this issue May 20, 2024 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@michaelweinold
Copy link
Contributor

As suggested by @cmutel, moving to fsspec would solve two issues with fs (pyfilesystem):

  1. The package is currently not under active development
  2. Code of the sort if not _WINDOWS_PLATFORM: import grp causes an error in WASM (Pyodide/JupyterLite-XEUS):

Note that this was patched in the current https://live.brightway.dev release:

import micropip
await micropip.install(
    'https://files.brightway.dev/fs-2.5.1-py2.py3-none-any.whl'
)

Still, it would be great to move to fsspec, which is supported by both Pyodide and emscipten-forge (via the pure Python channel).

This would close:

@michaelweinold michaelweinold added enhancement New feature or request help wanted Extra attention is needed labels May 20, 2024
@cmutel
Copy link
Member

cmutel commented May 20, 2024

@michaelweinold Told you this was a dirty hack 😛

@cmutel
Copy link
Member

cmutel commented May 28, 2024

Fixed in #66

@cmutel cmutel closed this as completed May 28, 2024
@michaelweinold
Copy link
Contributor Author

Noice! 🎉 Will remove the custom patch with the next bw_procesing release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants