fix: posters flash between videos in playlist #243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When playing multiple videos in a playlist the videojs
PosterImage
will be hidden using CSS. However, the native poster attribute will briefly appear while the new source loads. This doesn’t look very nice. The fix hides the poster for every video after the first in the playlist. This is a compromise given it's a minor issue. The fix aims to cover the majority of cases. It does not cover all edge cases. E.g. Should posters be shown if there is a pause between playlist items?autoadvance
> 0. Should the poster be hidden for the first video if the playlist has just repeated?I'm very new to the videojs world so I'm very aware there's a lot I don't know. Please let me know what I've missed.
Requirements Checklist