Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: posters flash between videos in playlist #243

Merged
merged 4 commits into from
Mar 15, 2023

Conversation

philjhale
Copy link
Contributor

Description

When playing multiple videos in a playlist the videojs PosterImage will be hidden using CSS. However, the native poster attribute will briefly appear while the new source loads. This doesn’t look very nice. The fix hides the poster for every video after the first in the playlist. This is a compromise given it's a minor issue. The fix aims to cover the majority of cases. It does not cover all edge cases. E.g. Should posters be shown if there is a pause between playlist items? autoadvance > 0. Should the poster be hidden for the first video if the playlist has just repeated?

I'm very new to the videojs world so I'm very aware there's a lot I don't know. Please let me know what I've missed.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

package-lock.json Outdated Show resolved Hide resolved
@philjhale philjhale requested a review from gkatsev March 8, 2023 13:55
src/playlist-maker.js Show resolved Hide resolved
@philjhale philjhale requested review from misteroneill and removed request for gkatsev March 13, 2023 17:38
@philjhale philjhale merged commit 80dde66 into videojs:main Mar 15, 2023
@philjhale philjhale deleted the fix/posters-flash-between-videos-2 branch March 15, 2023 14:18
@Essk Essk mentioned this pull request Apr 22, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants