feat: improve the playback timeout error experience #223
Conversation
src/plugin.js
Outdated
| player.reset(); | ||
| player.src(player.options_.sources); |
There was a problem hiding this comment.
player.options_.sources` won't be populated in all cases, I don't think. Here's a suggestion:
| player.reset(); | |
| player.src(player.options_.sources); | |
| const source = player.currentSource(); | |
| player.reset(); | |
| player.src(source); |
There was a problem hiding this comment.
Implemented suggestion.
| }); | ||
| player.on(dismissButton, 'click', function() { | ||
| display.close(); | ||
| }); |
There was a problem hiding this comment.
Unfortunately, these listeners create a small memory leak. Even if the display is closed and the elements are removed from the DOM, the internal Video.js listeners do not go away.
There's not a very easy way to find this, but I set a breakpoint in Video.js and exposed the DomData object. Then I tracked the number of listeners counted on this object as I created and dismissed the timeout modal multiple times. Each time the number of listeners increased by two.
I'd suggest adding the following:
display.one('modalclose', () => {
player.off(reloadButton);
player.off(dismissButton);
});That should clear these two listeners when these DOM elements disappear when the display is closed.
Description
Ticket: https://brightcove.atlassian.net/browse/WP-8