Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make the plugin ready for videojs 7 #117

Merged
merged 2 commits into from
May 2, 2018
Merged

fix: make the plugin ready for videojs 7 #117

merged 2 commits into from
May 2, 2018

Conversation

axten
Copy link
Contributor

@axten axten commented May 2, 2018

updated dependency declaration for newer videojs versions
fixes #116

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Unit Tests updated or fixed
    • Docs/guides updated
  • Reviewed by Two Core Contributors

@axten
fix: make the plugin work with videojs 6 and npm
161feda 
updated dependency declaration for newer videojs versions
fixes videojs#116
@gkatsev gkatsev mentioned this pull request May 2, 2018
Closed
@gkatsev
Copy link
Member

gkatsev commented May 2, 2018

Thanks, we forgot to update this.

@gkatsev gkatsev changed the title fix: make the plugin work with videojs 6 and npm fix: make the plugin ready for videojs 7 May 2, 2018
@gkatsev gkatsev merged commit 8d96f2a into videojs:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

videojs-errors does not work with npm and video.js 6
2 participants
@axten @gkatsev