Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sass support with esbuild #526

Closed
jaredcwhite opened this issue Apr 4, 2022 · 3 comments · Fixed by #542
Closed

feat: Sass support with esbuild #526

jaredcwhite opened this issue Apr 4, 2022 · 3 comments · Fixed by #542

Comments

@jaredcwhite
Copy link
Member

Currently Sass is only supported when the Webpack frontend bundler is used. We should provide it as an option for esbuild as well.

@ayushn21
Copy link
Member

ayushn21 commented Apr 4, 2022

We could potentially integrate http://github.com/ayushn21/dartsass-ruby to make Sass totally independent from the frontend bundler?

Since we have multiple bundler options, I'm not sure there's a lot of value in integrating it with the bundler .... but I could be wrong?

I don't mind moving that repo over to the Bridgetown organization either if that might make it easier to manage. I've got it set up on a friend's BT project where I ripped out Node completely as he had no JavaScript.

@jaredcwhite
Copy link
Member Author

@ayushn21 I appreciate the context there…I think it makes the most sense though to have Sass run within the esbuild process as a plugin, that way Sass files are importable from JS files and in other situations where the bundler's dependency tree is getting established.

In a broader conversation, I can envision down the road offering a "bundler-free" variant of a Bridgetown site setup, but in that case I don't feel the need to support Sass. Just use vanilla CSS for a zero-build-step config.

@ayushn21
Copy link
Member

ayushn21 commented Apr 4, 2022

I think it makes the most sense though to have Sass run within the esbuild process as a plugin, that way Sass files are importable from JS files and in other situations where the bundler's dependency tree is getting established.

Yeah that's fair, I did think of that potential use case after posting that comment :)

I can envision down the road offering a "bundler-free" variant of a Bridgetown site setup, but in that case I don't feel the need to support Sass. Just use vanilla CSS for a zero-build-step config.

Indeed, I agree! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants