Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing $ for Webpack's js rule in default config #399

Closed
jaredcwhite opened this issue Sep 25, 2021 · 0 comments · Fixed by #405
Closed

Missing $ for Webpack's js rule in default config #399

jaredcwhite opened this issue Sep 25, 2021 · 0 comments · Fixed by #405
Labels
bug Something isn't working

Comments

@jaredcwhite
Copy link
Member

The default Webpack config file currently has:

const jsRule = {
  test: /\.(js|jsx)/,
  use: {
    loader: "esbuild-loader",
    options: {
      target: 'es2016'
    },
  },
}

This will actually match any file with .js in it including foo.js.txt.bat.png. We need to ensure it's the file extension only by adding a dollar sign:

const jsRule = {
  test: /\.(js|jsx)$/,
  use: {
    loader: "esbuild-loader",
    options: {
      target: 'es2016'
    },
  },
}
@jaredcwhite jaredcwhite added the bug Something isn't working label Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant