Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird shell history issue after using sync.js #37

Closed
jaredcwhite opened this issue May 7, 2020 · 6 comments
Closed

Weird shell history issue after using sync.js #37

jaredcwhite opened this issue May 7, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@jaredcwhite
Copy link
Member

In iTerm, sometimes when I ctrl-c to quit the dev services, and then I press the up arrow key to browse shell history, instead of seeing the actual commands I just get garbage characters: ^[OA

Wonder if the sync.js script needs to output a newline or something upon termination to get the shell to work correctly.

@jaredcwhite jaredcwhite added the bug Something isn't working label May 7, 2020
@jaredcwhite jaredcwhite added this to the v0.14.0 "Hazelwood" milestone May 7, 2020
@jaredcwhite
Copy link
Member Author

I changed the last line of the start.js script to the following:

}).then(() => { console.log("Done.") }, () => {});

And that seems to clear up the issue.

@jaredcwhite
Copy link
Member Author

Bad news…I'm still seeing this issue even after the recent change. 😭

@jaredcwhite
Copy link
Member Author

Hopefully that last fix will do the trick! 🤞

@jaredcwhite
Copy link
Member Author

STILL having intermittent issues here, but I finally figured out both what the problem is and how to reproduce it every single time if need be (whew!)!

It's a bug with Yarn!

More details here: yarnpkg/yarn#4667

I'm not certain if Yarn v2 has fixed this or not, but I'm not feeling inspired to upgrade it on my computer right now so I'm leaving this issue open for the time being.

@jaredcwhite
Copy link
Member Author

Moved away from concurrently and using sync.js entirely in #281, so this will eventually be a moot point.

@jaredcwhite
Copy link
Member Author

happy this is no longer a thing, as yarn is out of the picture for the dev server!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant