Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Front matter defaults aren't merged properly into resource data #358

Closed
jaredcwhite opened this issue Aug 4, 2021 · 0 comments · Fixed by #359
Closed

Front matter defaults aren't merged properly into resource data #358

jaredcwhite opened this issue Aug 4, 2021 · 0 comments · Fixed by #359
Labels
bug Something isn't working

Comments

@jaredcwhite
Copy link
Member

jaredcwhite commented Aug 4, 2021 •
edited
Loading

I think it was a mistake to rely on a default "proc" instead of preemptively merging default data in. It means any "to_h"-related code paths are missing default data!

For example, in Liquid, resource.data.layout is missing in a layout template when the layout is set using defaults.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resource: switch from default proc to preemptive defaults bridgetownrb/bridgetown
1 participant
@jaredcwhite