Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ActiveSupport and refactor accordingly #31

Closed
jaredcwhite opened this issue May 2, 2020 · 1 comment
Closed

Include ActiveSupport and refactor accordingly #31

jaredcwhite opened this issue May 2, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@jaredcwhite
Copy link
Member

jaredcwhite commented May 2, 2020

I've come to discover I'm instinctually an "ActiveSupport-flavored" Rubyist, so not having all the niceties that come from ActiveSupport is a real bummer. I've already identified a number of places where both the Bridgetown internals and external plugin APIs could be improved substantially from utilizing ActiveSupport, so I think it's time to bite the bullet and get this added. I'm not sure if it will add a small amount of extra boot time, so that's something to consider, but if we're talking 100ms or less, I'm not too worried.

(Another good reason to add ActiveSupport: a major goal for this project is to find symbiotic ways for Bridgetown and Rails to work together and swim in the same developer communities, so the less friction there is for Rails folks to get up to speed with Bridgetown, the better.)

@jaredcwhite jaredcwhite added the enhancement New feature or request label May 2, 2020
@jaredcwhite
Copy link
Member Author

Note: changing milestone to 0.14 due to using HashWithIndifferentAccess for upcoming plugin DSL stuff, but really the bulk of the work to implement this will be in 0.15 and beyond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant