Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple webpack js entry points #246

Closed
rubys opened this issue Feb 16, 2021 · 2 comments · Fixed by #247
Closed

feat: support multiple webpack js entry points #246

rubys opened this issue Feb 16, 2021 · 2 comments · Fixed by #247
Labels
enhancement New feature or request

Comments

@rubys
Copy link

rubys commented Feb 16, 2021

Summary

webpack_path supports only a single js and css file. The request is to support multiple webpack entry points for js.

Motivation

The ruby2js.com site has multiple js files, one of which is quite large (the opal generated one). It would be best if the interactivity of the site didn't depend on everything having been loaded before anything can begin.

Reference-level explanation

Perhaps webpack_path could accept an optional second parameter?

Drawbacks

None? It should not affect those that do not use this feature.

Unresolved Questions

I' m not sure how best to handle someone defining multiple entry points in their webpack config but omitting the second parameter on the webpack_path. I haven't explored what the current behavior is in that case.

@jaredcwhite
Copy link
Member

Take a look at the updated webpack.config.js starter in PR #247 — that plus enhancements to webpack_path should now support multiple entry points, as well as other files in the manifest (fonts, images…)

@jaredcwhite jaredcwhite added this to the 0.20 milestone Feb 28, 2021
@jaredcwhite jaredcwhite added the enhancement New feature or request label Mar 2, 2021
@jaredcwhite
Copy link
Member

Rolling out with v0.20 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants