-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nikic/php-parser v5 #31
Comments
Good point, php-parser v5 has been released a couple weeks ago. However, Psalm still supports v4 only, so our dev dependencies are locked to php-parser v4, and we cannot run tests with v5 unless we create another composer.json just for Psalm (which could make sense, but adds a bit to maintenance). Should we just wait until Psalm becomes compatible with v5? Looks like it's a work in progress: vimeo/psalm#10567 |
FYI Psalm update is released |
@Fahl-Design AFAICS, vimeo/psalm#10567 has been merged into |
Oh, my bad.. |
What about require psalm as phar https://github.com/vimeo/psalm/blob/5.x/docs/running_psalm/installation.md#using-the-phar ? |
I usually find using tools via phars a bit cumbersome, as using composer is more convenient. That said, this option (from that same link) might be a good alternative with the best of both worlds PHPStan has been shipping as a phar but via composer, for some time already. I wish more tools took that approach. |
@acelaya & @snapshotpl are there any updates on the PR to upgrade to I am also experiencing issues when upgrading to Laravel 11 which requires v5 via phpunit. Thank you! |
I have created #33 as first step to upgrade |
Sorry for the delay. Let's merge #33, and I'll add support for php-parser v5 thereafter. |
@snapshotpl could you apply requested changes to your PR so that it can be merged and things can move forward? |
At first glance it looks like supporting nikic/php-parser v4 & v5 at the same time would be a pain. |
Fixed in 0.5.0! |
My app reported:
The text was updated successfully, but these errors were encountered: