Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns duplicate notes if one is embedded #901

Open
micaelarealign opened this issue Dec 3, 2024 · 7 comments
Open

Returns duplicate notes if one is embedded #901

micaelarealign opened this issue Dec 3, 2024 · 7 comments

Comments

@micaelarealign
Copy link

The results will end up including the note twice if it's been embedded somewhere.

Once as the original note, followed by the embeds of that note if they appear in other notes.

Ideally it would just return the original note instead of essentially duplicating the result.

@brianpetro
Copy link
Owner

I'm not sure what you mean by this. Please include screenshots 🌴

@micaelarealign
Copy link
Author

My notes are quite personal so I'd rather not take screenshots, but what I mean is something like this:

0.78 Part of a note

0.77 Part of a different note that's basically the same as the first because it contains an ![[embed]] of the same part of the first result

@brianpetro
Copy link
Owner

How would it be decided whether to display the first or second result? 🌴

@micaelarealign
Copy link
Author

I'm not sure I understand the question - from my point of view just the first result should be returned... in other words, why return a duplicate?

@brianpetro
Copy link
Owner

basically the same as

That doesn't seem like an exact duplicate to me.

Maybe I'm not understanding you correctly. A screenshot would be helpful. You can use a test vault if your notes are too sensitive 🌴

@micaelarealign
Copy link
Author

micaelarealign commented Dec 4, 2024

Honestly you're being a little immature, saying "basically the same" doesn't sound like a duplicate. How childish. Let me be clear. The result is exactly the same. The only difference is that it's rendered as an embed.

It feels like you're unnecessarily resistant to my reports. Like, who are you?

@brianpetro
Copy link
Owner

For clarity, whether something is exact-same (literally every character) or near-exact-same (even one space difference) makes a big difference with this sort of problem.

Reading between the lines, it seems like what's being asked here is to prevent rendering embedded links within the Smart Connections view.

That's what I implemented in brianpetro/jsbrains@46361c6

The update is now in the early-release version (available to project supporters) and will be included in the next update to the main version 🌴

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants