Expose db attribute of MYSQL client struct
#1244
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an accessor method that returns the current value of the `MSYQL` client struct's `db` attribute. The `MYSQL` client struct includes a field `char *db`. When the `session_track_schema` setting is enabled, this field will be updated using information from server-provided "OK" packets, keeping it in sync as the client switches between databases.
|
Sorry, I did not mean to open this against brianmario's repo at this time. I'll close for now. Apologies for the noise. |
|
This looks useful, I'd be glad to review and merge. |
|
Thanks, @sodabrew! I'm glad you think so. I'm still figuring out how this works by reading source code. I haven't found a lot of official documentation. I think this will break if session tracking is turned off. If so, this method needs a warning label. I want to test and document it properly. I'm hoping to come back with a PR that includes better documentation and unit tests in a few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an accessor method that returns the current value of the
MSYQLclient struct's
dbattribute.The
MYSQLclient struct includes a fieldchar *db. When thesession_track_schemasetting is enabled, this field will be updatedusing information from server-provided "OK" packets, keeping it in sync
as the client switches between databases.