Add project metadata to the gemspec #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sodabrew could I trouble you for a review? |
As per https://guides.rubygems.org/specification-reference/#metadata, add metadata to the gemspec file. This'll allow people to more easily access the source code, raise issues and read the changelog. These bug_tracker_uri, changelog_uri, documentation_uri, homepage_uri and source_code_uri links will appear on the rubygems page at https://rubygems.org/gems/mysql2 and be available via the rubygems API after the next release.
sodabrew
reviewed
Mar 9, 2020
| 'documentation_uri' => "https://www.rubydoc.info/gems/mysql2/#{s.version}", | ||
| 'homepage_uri' => s.homepage, | ||
| 'source_code_uri' => "#{s.homepage}/tree/#{s.version}", | ||
| } |
There was a problem hiding this comment.
Nit: colon syntax preferred vs. hash-rockets.
There was a problem hiding this comment.
Unfortunately, you can't use colon syntax when the keys are strings. The Rubygems spec requires the keys to be strings:
All keys and values must be Strings
https://guides.rubygems.org/specification-reference/#metadata
There was a problem hiding this comment.
Oh, well then. Let's merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
bug_tracker_uri,changelog_uri,documentation_uri,homepage_uri, andsource_code_urito the gemspec metadata.These project metadata will facilitate easy access to project information. The URI will be available on the Rubygems project page, via the rubygems API, and the
gemandbundlecommand-line tools with the next release.